https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13617
--- Comment #3 from Mikael Kanstrup <mikael.kanst...@gmail.com> ---
I tried to verify functionality and performance of change 21220 with the below
steps:
1. Download sample captures from wiki.wireshark.org/SampleCaptures
2. Run tshark on downloaded captures saving output to file:
for i in *; do echo "Dissecting $i ...";tshark -r $i >
../tshark-output/$i.txt; done
3. Run callgrind on tshark saving callgrind stats:
for i in *; do echo "Dissecting $i ..."; valgrind --tool=callgrind
--callgrind-out-file=../callgrind-output/$i.callgrind tshark -r $i > /dev/null;
done
4. Apply patch and repeat from 2
5. Diff tshark output w/ w/o patch
diff original patched > diff.txt
6. Diff callgrind total number of executed instructions w/ w/o patch
grep totals *.callgrind | cut -d ' ' -f 2 | paste -s -d+ - | bc
Unfortunately the patch changed http heuristics so cannot be applied (see
attached diff.txt). Performance gain on the first 80 or so pcaps was almost
zero. It seems only some specific pcaps see a significant performance gain from
this change so not sure it worth spending more time on this.
Feel free to close this bug item.
--
You are receiving this mail because:
You are watching all bug changes.___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
