https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14299
Bug ID: 14299
Summary: There should be an invalid check for pinfo->dst in
mrdisc
Product: Wireshark
Version: 2.2.11
Hardware: x86
OS: Windows 7
Status: UNCONFIRMED
Severity: Major
Priority: Low
Component: TShark
Assignee: bugzilla-ad...@wireshark.org
Reporter: yang...@hotmail.com
Target Milestone: ---
Build Information:
None
--
There should be an invalid check for pinfo->dst in
epan/dissectors/packet-mrdisc.c.
171 static int
172 dissect_mrdisc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *parent_tree,
void* data _U_)
173 {
174 proto_tree *tree;
175 proto_item *item;
176 guint8 type;
177 int offset = 0;
178 guint32 dst = g_htonl(MC_ALL_ROUTERS);
179
180 /* Shouldn't be destined for us */
181 if (memcmp(pinfo->dst.data, &dst, 4))
182 return 0;
183
184 col_set_str(pinfo->cinfo, COL_PROTOCOL, "MRDISC");
185 col_clear(pinfo->cinfo, COL_INFO);
(code snippet from wireshark source code 2.2.11)
Below is the patch for the bug.
- if (memcmp(pinfo->dst.data, &dst, 4))
- return 0;
+ if ((pinfo->dst.type != AT_IPv4) || memcmp(pinfo->dst.data, &dst, 4))
+ return 0;
--
You are receiving this mail because:
You are watching all bug changes.___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
