https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14303
Bug ID: 14303
Summary: There is a code snippet that does not properly update
bluetooth conversation data
Product: Wireshark
Version: 2.2.11
Hardware: x86
OS: Windows 7
Status: UNCONFIRMED
Severity: Major
Priority: Low
Component: TShark
Assignee: bugzilla-ad...@wireshark.org
Reporter: yang...@hotmail.com
Target Milestone: ---
Build Information:
None
--
There is a code snippet that does not properly update bluetooth conversation
data.
Below is the code. (line 1209)
1137 void
1138 bluetooth_add_address(packet_info *pinfo, address *addr, guint32
stream_number,
1139 const gchar *setup_method, guint32 setup_frame_number,
1140 gboolean is_video, void *data)
1141 {
1142 address null_addr;
...
1205 /*
1206 * Update the conversation data.
1207 */
1208 /* Free the hash if already exists */
1209 rtp_dyn_payload_free(p_conv_data->rtp_dyn_payload);
1210
1211 g_strlcpy(p_conv_data->method, setup_method,
MAX_RTP_SETUP_METHOD_SIZE+1);
1212 p_conv_data->frame_number = setup_frame_number;
1213 p_conv_data->is_video = is_video;
Below is the patch.
/*
* Update the conversation data.
*/
- /* Free the hash if already exists */
- rtp_dyn_payload_free(p_conv_data->rtp_dyn_payload);
+ /* Free the hash if a different one already exists */
+ if (p_conv_data->rtp_dyn_payload != rtp_dyn_payload) {
+ rtp_dyn_payload_free(p_conv_data->rtp_dyn_payload);
+ p_conv_data->rtp_dyn_payload = rtp_dyn_payload_ref(rtp_dyn_payload);
+ } else {
+ DPRINT(("passed-in rtp_dyn_payload is the same as in the
conversation"));
+ }
--
You are receiving this mail because:
You are watching all bug changes.___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
