https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14698
Peter Wu <pe...@lekensteyn.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anders.bro...@ericsson.com,
| |pe...@lekensteyn.nl
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
--- Comment #1 from Peter Wu <pe...@lekensteyn.nl> ---
Confirmed. The offending code is:
3365 dissect_hsdsch_type_2_channel_info(tvbuff_t *tvb, packet_info *pinfo,
proto_tree *tree,
...
3561
/********************************************************************/
3562 /* Now read the MAC-d/c PDUs for each block using info from
headers */
3563 for (n=0; n < number_of_pdu_blocks; n++) {
3564 for (j=0;j<no_of_pdus[n];j++) {
3565
3566 /*Configure (signal to lower layers) the PDU!*/
3567 macinf->content[j] =
lchId_type_table[lchid[n]+1];/*hsdsch_macdflow_id_mac_content_map[p_fp_info->hsdsch_macflowd_id];*/
/*MAC_CONTENT_PS_DTCH;*/
lchid[n]+1 = 15+1=16 while lchId_type_table only has 16 elements (off-by-one).
3568 macinf->lchid[j] = (guint8)lchid[n]+1; /*Add 1 since
C/T is zero indexed? ie C/T =0 => L-CHID = 1*/
3569 macinf->macdflow_id[j] = p_fp_info->hsdsch_macflowd_id;
3570 /*Figure out RLC_MODE based on MACd-flow-ID, basically
MACd-flow-ID = 0 then it's SRB0 == UM else AM*/
3571 rlcinf->mode[j] =
lchId_rlc_map[lchid[n]+1];/*hsdsch_macdflow_id_rlc_map[p_fp_info->hsdsch_macflowd_id];*/
This code was introduced in commit 37fdb21ec2e935c55d38541a37d5325272c0818f.
Anders, any idea what the correct fix is? Should "+1" be removed?
--
You are receiving this mail because:
You are watching all bug changes.___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
