https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15018

--- Comment #12 from Guy Harris <[email protected]> ---
(In reply to Jaap Keuter from comment #7)
> It seems as though the conversion from circuit to conversation wasn't
> complete. I've run into two problems. 
> find_or_create_conversation() can not work with
> conversation_create_endpoint_by_id() because:
> 1) ENDPOINT_ISDN (as used here) has no PT_ISDN counterpart, hence cannot be
> produced by conversation_pt_to_endpoint_type()

That's fixed by the latest change - if an endpoint has been created and
attached to the packet_info structure, find_or_create_conversation() now uses
the data from the endpoint, rather than from other fields in the packet_info
structure.

> 2) The conversation isn't found, since it's searched with full address
> tuples instead of NO_ADDR_B|NO_PORT_B, and then created with full address
> tuples instead of NO_ADDR_B|NO_PORT_B
> Subsequently try_conversation_dissector_by_id() fails because it's looking
> in the wrong conversation table, the one without the ADDR_B and PORT_B.

In which dissector is that failing?  The new fix works with the ISDN4BSD
capture.

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <[email protected]>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:[email protected]?subject=unsubscribe

Reply via email to