https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15251
Johannes Altmanninger <aclo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aclo...@gmail.com,
| |t...@compton.nu
--- Comment #3 from Johannes Altmanninger <aclo...@gmail.com> ---
CCing Tom Hughes as the undefined shift was introduced last week in [1].
I tried to find out how to properly fix this but I haven't had any luck so far.
I don't understand some things, in particular, RFC 5456 states that the
subclass field should be interpreted as an unsigned 7-bit integer if the 'C'
bit is 0, but the code in uncompress_subclass returns -1 for a lot of those
cases. Is there a place where the format is documented? Perhaps [3] acts as
canonical source?
Also I'm pretty sure we should use 0x40 instead of 40 in [4]. This seems to be
another unrelated issue.
[1]
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blobdiff;f=epan/dissectors/packet-iax2.c;h=471d582bddf295c4379df12083ba9ebd801a4f3a;hp=589f1f0298292841a24f6b42d9f3026315d67d8e;hb=27070dd05964823adefbd159595e61b515c52e49;hpb=99c62bf79710a8fa97d368fa0b2c54b9d1cc6484
[2] https://tools.ietf.org/html/rfc5456#page-44
[3] https://github.com/asterisk/asterisk/blob/master/channels/chan_iax2.c#L1828
[4]
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blob;f=epan/dissectors/packet-iax2.c;h=aafd9eae3bc1f2ee907b19baf56082b04c5dc1ea;hb=HEAD#l1896
--
You are receiving this mail because:
You are watching all bug changes.___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
