URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4bb6c2d395ac1e30e116bc2780fa143df2dc1ab Submitter: Michael Mann (mman...@netscape.net) Changed: branch: master Repository: wireshark
Commits: a4bb6c2 by Gerald Combs (ger...@wireshark.org): Make a deep copy of our filename in RecentFileStatus. QStrings are implictly shared as described at http://doc.qt.io/qt-5/implicit-sharing.html. This is normally useful, but RecentFileStatus is passed a QString before it does its work in a separate thread. Make a deep copy of the filename in order to ensure local ownership and to avoid having to fool around with a QMutex (which might not be recognized by ThreadSanitizer[1] or Helgrind[2]). Remove getFilename since it was unused. [1] https://github.com/google/sanitizers/issues/460 [2] http://valgrind.org/docs/manual/hg-manual.html Change-Id: I5b5c329505ed8c02d30043a2a6d1ded625924b9f Reviewed-on: https://code.wireshark.org/review/25572 Reviewed-by: Gerald Combs <ger...@wireshark.org> Petri-Dish: Gerald Combs <ger...@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mman...@netscape.net> Actions performed: from e3a7676 quic: fix secret memleaks. adds a4bb6c2 Make a deep copy of our filename in RecentFileStatus. Summary of changes: ui/qt/recent_file_status.cpp | 9 ++++----- ui/qt/recent_file_status.h | 4 +--- 2 files changed, 5 insertions(+), 8 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe