Submitter: Michael Mann (mman...@netscape.net)
Changed: branch: master
a4bb6c2 by Gerald Combs (ger...@wireshark.org):
Make a deep copy of our filename in RecentFileStatus.
QStrings are implictly shared as described at
http://doc.qt.io/qt-5/implicit-sharing.html. This is normally useful,
but RecentFileStatus is passed a QString before it does its work in a
Make a deep copy of the filename in order to ensure local ownership and
to avoid having to fool around with a QMutex (which might not be
recognized by ThreadSanitizer or Helgrind).
Remove getFilename since it was unused.
Reviewed-by: Gerald Combs <ger...@wireshark.org>
Petri-Dish: Gerald Combs <ger...@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mman...@netscape.net>
from e3a7676 quic: fix secret memleaks.
adds a4bb6c2 Make a deep copy of our filename in RecentFileStatus.
Summary of changes:
ui/qt/recent_file_status.cpp | 9 ++++-----
ui/qt/recent_file_status.h | 4 +---
2 files changed, 5 insertions(+), 8 deletions(-)
Sent via: Wireshark-commits mailing list <email@example.com>