Submitter: Anders Broman (a.broma...@gmail.com)
Changed: branch: master
Repository: wireshark


1d999de by Gerald Combs (ger...@wireshark.org):

    Qt: Update recent status via a non-blocking connection.
    Connect our recent file status signal using a Qt::QueuedConnection
    instead of a Qt::BlockingQueuedConnection. As described at
    QueuedConnection makes a copy of the argument list while
    BlockingQueuedConnection passess the list directly.
    This fixes what appears to be a false positive reported by
    ThreadSanitizer. Cross-thread signals are protected by a QMutex, but
    qmutex_mac.cpp in the Qt5 sources uses a Mach semaphore. The
    ThreadSanitizer manual says it supports pthread mutexes and compiler
    atomic operations but doesn't mention Mach semaphores.
    Change-Id: Icb8a63d7d0bdfe985ab8274757043ef45ae4bcde
    Reviewed-on: https://code.wireshark.org/review/25576
    Reviewed-by: Gerald Combs <ger...@wireshark.org>
    Petri-Dish: Gerald Combs <ger...@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <s...@bjorlykke.org>
    Reviewed-by: Anders Broman <a.broma...@gmail.com>

Actions performed:

    from  90b3e72   Delete an out-of-date comment.
    adds  1d999de   Qt: Update recent status via a non-blocking connection.

Summary of changes:
 ui/qt/recent_file_status.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits

Reply via email to