Submitter: Roland Knall (rkn...@gmail.com)
Changed: branch: master
Repository: wireshark


9198448 by Peter Wu (pe...@lekensteyn.nl):

    Qt: fix crash in packet dialog on changing selection
    "((capture_file_t *)cap_file_)->edt" is documented in cfile.h to cover
    the currently selected packet (in the packet list). But in the packet
    dialog, the packet selection is irrelevant and the data from a different
    dissection tree must be used.
    Change-Id: Ieaea3cf862d47540e7f6b6c84c1a2fa6945a877b
    Fixes: v2.5.0rc0-1532-g56a130a152 ("ByteViewText: Remove epan dependancy")
    Bug: 14246
    Reviewed-on: https://code.wireshark.org/review/25437
    Petri-Dish: Peter Wu <pe...@lekensteyn.nl>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rkn...@gmail.com>

Actions performed:

    from  f0db412   Convert coloring rules dialog to use model.
    adds  9198448   Qt: fix crash in packet dialog on changing selection

Summary of changes:
 ui/qt/byte_view_tab.cpp | 37 +++++++++++++++++++++++++++++--------
 ui/qt/byte_view_tab.h   |  6 +++++-
 ui/qt/packet_dialog.cpp |  2 +-
 3 files changed, 35 insertions(+), 10 deletions(-)
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits

Reply via email to