URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be50371666a7a4497078bb7e644a788e0e169d6d
Submitter: Peter Wu (pe...@lekensteyn.nl)
Changed: branch: master-2.6
Repository: wireshark
Commits:
be50371 by Peter Wu (pe...@lekensteyn.nl):
Qt: make "Save As" in Follow Streams usable
For formats other than "Raw" and "UTF-8", the written file does not
match the actual stream data. It would be duplicated in strange ways.
Executing the "Save As" action twice while the dialog is open would also
write two different files (huh?).
As a quick fix, just replace the strange save logic by writing the text
field contents. A functional difference is that previously it would
write data while parsing the "follow data" list, now it uses the text
field contents. That data will now be truncated after 500 MB.
Bug: 14933
Change-Id: I498676389d0da3ac070346d6903bd2e6b0fc7674
Fixes: v1.11.0-rc1-2538-g80f9326b2f ("Add TCP/UDP/SSL Follow feature to
QtShark")
Reviewed-on: https://code.wireshark.org/review/28663
Petri-Dish: Peter Wu <pe...@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <pe...@lekensteyn.nl>
(cherry picked from commit 16953695d734555a4472bada9d2dec799544d619)
Reviewed-on: https://code.wireshark.org/review/28684
Actions performed:
from 6456cce If we explicitly started a new page, print a column header
line if necessary.
adds be50371 Qt: make "Save As" in Follow Streams usable
Summary of changes:
ui/qt/follow_stream_dialog.cpp | 72 +++++++++++++-----------------------------
ui/qt/follow_stream_dialog.h | 2 --
2 files changed, 22 insertions(+), 52 deletions(-)
___________________________________________________________________________
Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
