URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aca17315eb2815da52fb2bef2977935301a018d3 Submitter: "Gerald Combs <ger...@wireshark.org>" Changed: branch: master-3.2 Repository: wireshark
Commits: aca1731 by Gerald Combs (ger...@wireshark.org): Qt: We show preference panes using their module names. PreferencesDialog::setPane takes a preference module name. Fix a comparison in PrefModuleTreeView::setPane and update some variable names in order to make things a bit more obvious. Modernize some related code while we're here. Bug: 16250 Change-Id: I8f4c7e5261a219e3f32e6e9a71574d81b1852219 Reviewed-on: https://code.wireshark.org/review/35304 Petri-Dish: Gerald Combs <ger...@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <ger...@wireshark.org> (cherry picked from commit 7be2d964f04d8158782719ed41f3342c7f1c126d) Reviewed-on: https://code.wireshark.org/review/35314 Actions performed: from a888282 ieee1905: Fix an incorrect bit usage in the Client Association Even TLV. add aca1731 Qt: We show preference panes using their module names. Summary of changes: ui/qt/address_editor_frame.cpp | 3 +-- ui/qt/main_window.cpp | 20 ++++++++++---------- ui/qt/main_window.h | 2 +- ui/qt/main_window_slots.cpp | 4 ++-- ui/qt/preference_editor_frame.cpp | 3 +-- ui/qt/preferences_dialog.cpp | 4 ++-- ui/qt/preferences_dialog.h | 7 ++++++- ui/qt/widgets/pref_module_view.cpp | 24 ++++++++++++------------ ui/qt/widgets/pref_module_view.h | 4 ++-- ui/qt/wireless_frame.cpp | 2 +- 10 files changed, 38 insertions(+), 35 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe