URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e8b03f93f99028fdef092ddec4e29cf9e3bdf1c Submitter: "Guy Harris <g...@alum.mit.edu>" Changed: branch: master-3.0 Repository: wireshark
Commits: 5e8b03f by Guy Harris (g...@alum.mit.edu): Make the TTL field unsigned, but keep warning if the high-order bit is set. See RFC 2181, section 8 (and RFC 1035 erratum 2130, which notes that section 3.2.1 says the TTL is signed but section 4.1.3 says it's unsigned); RFC 2181 section 8 says "unsigned, but avoid sending values that have the uppermost bit set, and treat values with the uppermost bit set as a value of 0". (STD 13 = RFC 1034, the "concepts and facilities" DNS RFC, plus RFC 1035, the "implementation and specification" DNS RFC.) Change-Id: I9be6ac4f190f62dafbc45d1923a95f8f21306a7d Reviewed-on: https://code.wireshark.org/review/35343 Petri-Dish: Guy Harris <g...@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <g...@alum.mit.edu> (cherry picked from commit 8275036fda8a7a5b9d0819c0ea3e3e26ad6e45ec) Reviewed-on: https://code.wireshark.org/review/35361 Actions performed: from 3987662 Win32: Fix the Export Packet Dissections dialog title. add 5e8b03f Make the TTL field unsigned, but keep warning if the high-order bit is set. Summary of changes: epan/dissectors/packet-dns.c | 50 ++++++++++++++++++++++++++++++++++++++------ 1 file changed, 44 insertions(+), 6 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe