Submitter: "Pascal Quantin <pas...@wireshark.org>"
Changed: branch: master
Repository: wireshark


69a4769 by Pau Espin Pedrol (pes...@sysmocom.de):

    rlcmac: Fix bug receiving RA cap
    It seems the assumptions regarding maximum number of RA capabilitites
    in one message were wrong. Doing some rough calculations, each RA
    capabilitiy value (without extensions) can take around 20ish bits, which
    means for a message containing up to 52 bytes that quite a lot of
    different values could be theoretically fed in. Let's be safe and
    increase the array size to be able to handle all different access
    technologies listed in See TS 24.008 table 10.5.146 following
    * "The MS Radio Access capability is a type 4 information element, with a 
maximum length of 52 octets."
    * "Among the three Access Type Technologies GSM 900-P, GSM 900-E and GSM 
900-R only one shall be present."
    * "the mobile station should provide the relevant radio access
      capability for either GSM 1800 band OR GSM 1900 band, not both".
    Port from osmo-pcu.git 7faa5da209d0ef48fe593603c217615f09fb61fb.
    Related: https://osmocom.org/issues/4463
    Change-Id: Ief5189f88ba0e4970847567c9a15b1ada8b9df4b
    Reviewed-on: https://code.wireshark.org/review/36573
    Reviewed-by: Harald Welte <lafo...@gnumonks.org>
    Petri-Dish: Pascal Quantin <pas...@wireshark.org>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pas...@wireshark.org>

Actions performed:

    from  badbc3c   rlcmac: Don't pass array element to CSN1 descriptors
     add  69a4769   rlcmac: Fix bug receiving RA cap

Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.h | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits

Reply via email to