URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0334b6af556ecc7b1ac5e65ed3216b8c17a642d5
Submitter: "Alexis La Goutte <alexis.lagou...@gmail.com>"
Changed: branch: master
Repository: wireshark
Commits:
0334b6a by John Thacker (johnthac...@gmail.com):
Fix use of _ret_uint() for UINT_{BYTES,STRING} when _ret_length() is wanted
_ret_uint() doesn't work for UNIT_BYTES and UINT_STRING. In these cases,
what was wanted was the total length in order to increment the offset.
(Note _ret_length() includes the fixed width length field; these were
written wanting only the value in the length field, not the total length.)
Change-Id: I9c7c2bc644c414d02eec3fff481e8863778f51fa
Reviewed-on: https://code.wireshark.org/review/38006
Petri-Dish: Alexis La Goutte <alexis.lagou...@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Mathieson <martin.r.mathie...@googlemail.com>
Reviewed-by: Alexis La Goutte <alexis.lagou...@gmail.com>
Actions performed:
from a44bdf5 FP: add unsigned item with _uint calls rather than _int()
add 0334b6a Fix use of _ret_uint() for UINT_{BYTES,STRING} when
_ret_length() is wanted
Summary of changes:
epan/dissectors/packet-ppp.c | 20 +++++++++-----------
epan/dissectors/packet-slsk.c | 4 ++--
2 files changed, 11 insertions(+), 13 deletions(-)
___________________________________________________________________________
Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe
