URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ac54e27b0c3f6d75d3e33714e0e3440b583aab7 Submitter: "Anders Broman <a.broma...@gmail.com>" Changed: branch: master Repository: wireshark
Commits: 4ac54e2 by Stig Bjørlykke (s...@bjorlykke.org): Qt: Fix status message issues in find packet search Fix some status message and tooltip issues introduced when enabling autocomplete on find packet search in g0162ba73. 1. Enable or disable completion only when search type is changed. This setting is used in checkDisplayFilter(), which used to be called *before* changing allowCompletion in updateWidgets(), and this was causing issues with wrong status messages. 2. Check filter (usually triggered by changes in the search line) or reset filter syntax (added by DisplayFilterEdit) when search type is changed. This will trigger an update of the status message and the tooltip. 3. Stop checking display filter if not doing completion (not display filter search). This will avoid setting a status message from a previous illegal display filter. Ping-Bug: 16638 Change-Id: I1534d9494cc4d7b7a0583cb845c091ae709458ae Reviewed-on: https://code.wireshark.org/review/38061 Petri-Dish: Stig Bjørlykke <s...@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathie...@googlemail.com> Reviewed-by: Anders Broman <a.broma...@gmail.com> Actions performed: from 12242e1 STUN: fix heuristic for ChannelData payload add 4ac54e2 Qt: Fix status message issues in find packet search Summary of changes: ui/qt/search_frame.cpp | 14 ++++++++++---- ui/qt/widgets/display_filter_edit.cpp | 5 +++-- ui/qt/widgets/field_filter_edit.cpp | 3 ++- ui/qt/widgets/syntax_line_edit.cpp | 8 +++++--- ui/qt/widgets/syntax_line_edit.h | 2 +- 5 files changed, 21 insertions(+), 11 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe