URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75884bd0110558d4d08f802075b7086b371fd61f Submitter: "Anders Broman <a.broma...@gmail.com>" Changed: branch: master Repository: wireshark
Commits: 75884bd by Martin Mathieson (martin.mathie...@keysight.com): packet-bthci-cmd: For LE Supported Features, fix loop to exit after 8 items. I haven't been able to find the appropriate spec, but either there is a limit to the number of features bytes to add and this patch is needed, or the (i < 8) part should be dropped. As it is the other data and expert info for 'unknown' fields will never be reached. Detected by cppcheck: epan/dissectors/packet-bthci_cmd.c:9183:72: warning: Condition 'i<8' is always true [knownConditionTrueFalse] while (tvb_captured_length_remaining(tvb, offset) > 0 && i < 8) { ^ epan/dissectors/packet-bthci_cmd.c:9181:25: note: Assignment 'i=0', assigned value is 0 guint8 i = 0; ^ epan/dissectors/packet-bthci_cmd.c:9183:72: note: Condition 'i<8' is always true while (tvb_captured_length_remaining(tvb, offset) > 0 && i < 8) { Change-Id: Icfef0e9142a58aa1c525df9b7daf0aa820039167 Reviewed-on: https://code.wireshark.org/review/38049 Petri-Dish: Martin Mathieson <martin.r.mathie...@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathie...@googlemail.com> Reviewed-by: Anders Broman <a.broma...@gmail.com> Actions performed: from 30413ed PFCP: Add GUID field with correct API and length. add 75884bd packet-bthci-cmd: For LE Supported Features, fix loop to exit after 8 items. Summary of changes: epan/dissectors/packet-bthci_cmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe