URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dae7f769e8b6f3afc46a28bac5ab6c3449b870e5 Submitter: "Guy Harris <ghar...@sonic.net>" Changed: branch: master Repository: wireshark
Commits: dae7f76 by Guy Harris (ghar...@sonic.net): tacacs: various fixes and cleanups. Update URL for the TACACS+ I-D - point to the IETF site. Fix code indentation. Use proto_tree_add_item_ret_uint() to get string lengths when adding them to the protocol tree. Put the username and password under the top-level tree item, rather than at the top level themselves. The username and password are counted strings, and are not null-terminated; make them FT_STRING rather than FT_STRINGZ. Change-Id: Ia974937ade5908f98c0b527586e8ac15c3ffb907 Reviewed-on: https://code.wireshark.org/review/38130 Petri-Dish: Guy Harris <ghar...@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <ghar...@sonic.net> Actions performed: from b1753ce Qt: Add debugging ifdefs for the packet diagram. add dae7f76 tacacs: various fixes and cleanups. Summary of changes: epan/dissectors/packet-tacacs.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe