URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a42286524a0e23f5944e988e672a07a5fb395c69 Submitter: "Guy Harris <ghar...@sonic.net>" Changed: branch: master Repository: wireshark
Commits: a422865 by Guy Harris (ghar...@sonic.net): Only do trailing stray character checks on FT_STRING fields. FT_STRINGZ means "terminated by a null character", so there can't be non-null characters following the terminating null. FT_STRINGZPAD doesn't only mean "padded with nulls"; there are protocols where a string that's not the full length of the part of the packet for the string has a null terminator but isn't guaranteed to be fully padded with nulls. We can later add a separate type for fields where we really *should* check that the padding is all nulls. Change-Id: I5964817b4b847cb4db73f8ac673141052e8ef92c Reviewed-on: https://code.wireshark.org/review/38230 Petri-Dish: Guy Harris <ghar...@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <ghar...@sonic.net> Actions performed: from b228b5a Add Arinc 615A dissector add a422865 Only do trailing stray character checks on FT_STRING fields. Summary of changes: epan/proto.c | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe