On Wed, Aug 09, 2006 at 06:25:59PM +0100, Neil Piercy wrote: > Should call_dissector include explicit null handle checks, and if so, > should it:- > > a) g_assert - the simple patch attached > b) fallback to doing a data decode (as disabled protocols do) > c) try to invoke the wireshark exception handling for the packet
IMO, a) is valid behaviour and while b) might be interesting I haven't thought through all the consequences in other places that could happen if we made null handles a feature. Committed revision 18869. Thanks! Joerg -- Joerg Mayer <[EMAIL PROTECTED]> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
