Gerald Combs wrote:
> I'm in the process of moving the contents of airpdcap to epan/crypt.
> Once that's done I'll add it to the distribution.
Some warnings from my build on OS X 10.4:
In file included from airpdcap.c:5:
airpdcap_int.h:62: warning: malformed '#pragma pack' - ignored
airpdcap_int.h:109: warning: malformed '#pragma pack' - ignored
airpdcap.c:1045: warning: comparison of unsigned expression < 0 is
always false
In file included from airpdcap_ccmp.c:5:
airpdcap_int.h:62: warning: malformed '#pragma pack' - ignored
airpdcap_int.h:109: warning: malformed '#pragma pack' - ignored
In file included from airpdcap_md5.c:5:
airpdcap_int.h:62: warning: malformed '#pragma pack' - ignored
airpdcap_int.h:109: warning: malformed '#pragma pack' - ignored
In file included from airpdcap_tkip.c:5:
airpdcap_int.h:62: warning: malformed '#pragma pack' - ignored
airpdcap_int.h:109: warning: malformed '#pragma pack' - ignored
In file included from airpdcap_wep.c:5:
airpdcap_int.h:62: warning: malformed '#pragma pack' - ignored
airpdcap_int.h:109: warning: malformed '#pragma pack' - ignored
Do those structures need "#pragma pack"? If so, could the code be
changed not to require that? Not all C compilers support "#pragma
pack", as far as I know, and even those that do apparently don't support
it in the same way, for example:
$ gcc --version
powerpc-apple-darwin8-gcc-4.0.0 (GCC) 4.0.0 20041026 (Apple Computer,
Inc. build 4061)
doesn't like those "#pragma pack" items.
In addition:
1) Should all the crypt-XXX.[ch] files in the epan directory be moved
to the epan/crypt directory?
2) Can any code be shared between epan/crypt-md5.[ch] and
epan/crypt/airpdcap_md5.[ch]?
_______________________________________________
Wireshark-dev mailing list
[email protected]
http://www.wireshark.org/mailman/listinfo/wireshark-dev
