Hi Steve, I was wondering whether it couldn't be easier to replace the g_strsplit of gtk1.2 by the one implemented in gtk2. It will be far more easier to avoid problems in the current dissectors and in the future.
Write a new header file (w_strsplit.h) which defines a macro replacing the string g_strsplit by w_strsplit and implements the function as a copy of g_strsplit defined in gtk2. It should be defined only if using gtk1.2 of course ... Include the header w_strplsit.h in each file using g_strsplit ... and the work is done. No more headache ! What do you think? Regards, Sebastien Tandel Stephen Fisher wrote: > On Thu, Jan 18, 2007 at 01:55:05AM +0100, Sebastien Tandel wrote: > > >> just a remember for this patch against a crash of wireshark with >> gtk1.2 when using packet length statistics window. The crash was due >> to a difference of implementation of g_strsplit between gtk1.2 and >> gtk2. >> > > Thanks for the reminder. I have committed your change as svn revision > 20518. > > >> (see http://www.wireshark.org/lists/wireshark-dev/200612/msg00218.html >> for more details and a review of the dissectors using this function) >> > > Thanks for your hard work identifying these items. I'll take a closer > look as time permits. > > > Steve > > _______________________________________________ > Wireshark-dev mailing list > [email protected] > http://www.wireshark.org/mailman/listinfo/wireshark-dev > _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
