Thank you for your comment and insight. I'll implement them and see how it looks.
--Kriang Martin Mathieson wrote: > > > This patch only touches K12's part. There are a few parameters > for FP that the patch still does not provide together with my idea > for > future > work: > - The UMTS release number - This will go into a preference setting. FP > dissector > should use a default release from preference when it is not given in > packet info. > > > This sounds OK, 0 in the struct could mean that the preference setting > should be used. There are only one or two places where the > sub-release can affect the message format, these are currently tied to > the DCT2000 variant. I think, though, that because the message > formats are based on 3 different specs, it may be better if I convert > this into a quarter (e.g. 0306 for the March '06 release onwards). > Again a preference could be used if the info isn't available from the > file. > > > > - DCH CRC flag - By tweaking .rf5 file and feed to K12 reader, I found > that it > relies on how many bytes remain after the transport block. If there > are enough > bytes, it always treat the last 2 bytes as CRC. > > > This seems to be a safe thing to do in practice, even although the > spec has (I think) 0-2 bytes of spare extension bytes for DCH, and > more for other channel types. The FP dissector currently does this > for EDCH channels, as our stack used to always add it. > > Best regards, > Martin > >------------------------------------------------------------------------ > >_______________________________________________ >Wireshark-dev mailing list >[email protected] >http://www.wireshark.org/mailman/listinfo/wireshark-dev > > _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
