On Wed, Mar 07, 2007 at 10:36:00AM +0100, Ulf Lamping wrote: > > or d) no one found the time to think about it - I've started to look at > it but was interrupted and couldn't get back to it since then :-(
Ah, ok, I guess I'm still a little impatient as a 'new developer' :-) > I had a look at your patch and applied it to my personal tree, noting > some things: > > 1) We already have a Copy submenu in both context menus, your function > belongs into this (e.g. /Copy/As Filter) - right below > Summary/Description IMHO ACK > 2) The Copy entry in the main menu belongs in Edit (e.g. /Edit/Copy/As > Filter) and not in Analyze (we need to add all the other Copy > functionality into this menu as well, probably later) Hmm... The Copy items in the Edit menu are still iffed-out. Should I un-if them too then? Was there any reason to have them iffed-out that is still valid? > Could you change this and send a new patch? Will do! Thanks for taking the time to look at it. Cheers, Sake _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
