Hi Owen, I've just had a very brief skim through this; A couple of points:
* The ccitt crc16 routines are already in crc16.h - please could you use them rather than reinventing this particular wheel? * Your patch messes up the indentation in libpcap.c - please can you sort it out? * I'm not generally a fan of 500-line functions - any chance the offender could be split up a bit? * Please could you create a Protocols/ieee802154 page on the wiki, and add an example capture, so we can see what your dissector does? Many thanks for your contribution. Richard Owen Kirby wrote: > Wireshark-dev, > > Following the discussion with Mikko Saarnivala from Sensinode, and Guy > Harris, I have revised the IEEE 802.15.4 patch to use a standard > pseudo-header. The updated patch has been tested using the Wireshark SVN > sources as of yesterday. > > This patch adds the dissectors for the IEEE 802.15.4 MAC layer, as well > as support for the DLT_IEEE802_15_4 type. > > Thanks, > Owen Kirby _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
