Hi, I've a few questions on this. First of all what's the status of this external tpncp.dat file? Under what license is it distributed?
I'm not sure if I like the idea of such a 'flexible' dissector since we never can be sure of the quality of the dissector since it depends on the tpncp.dat file being loaded, and that is 'out of our control'. I also don't like the location in the plugin directory for that matter, but that is just an implementation detail. just my E0.02. Jaap Valery Sigalov wrote: > Hello, > > I attached the new protocol dissector source code (packet-tpncp.c). > > The ‘Makefile.common’ from ‘epan/dissectors’ directory was changed like > following: the name of the new source file was added to ‘DISSECTOR_SRC’ > macro. > > The new Wiki page on the protocol was created > (http://wiki.wireshark.org/TPNCP). > > The example of tpncp.dat file needed for proper work of TPNCP dissector > attached to protocol Wiki page. This file *should not* be the part of > the project and distributed separately with AudioCodes’ SW Release > Package. > > The sample captures (tpncp_udp.pcap and tpncp_tcp.pcap) were added to > the SampleCaptures page. > > The fuzz testing passed OK. > > The following platforms were tested – Windows 2000/XP/2003/Vista, Linux > RHEL/Fedora/Suse/Debian, Sun Solaris 9 and 10 (Intel and Sparc). > > > > Please review the attached sources if they are ok and add them to > repository. Please give me the feedback if I need to change something. > > > > Thank you, > > Valery. > _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
