Hello, your changes in asn2wrs.py look good.
Note that packet-$(PROTOCOL_NAME)-template.h and $(PROTOCOL_NAME).asn files are optional and are not used in many protocols. Regards, Tomas > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Joerg Mayer > Sent: Monday, September 24, 2007 9:06 AM > To: [email protected] > Subject: [Wireshark-dev] RFC: Revised Makefile(s) for asn1/ directory > > Hello, > > below you'll find an initial patch that is intended to improve the > build (and packaging) situation in the asn1 dir. I only intended > to write a small patch but looking at the build situation in the > asn1/ directory showed several things in need of improvement: > > - Generated files in the asn1 dirs are checked in > - Makefiles add files in three places: > asn1/protocol/Unix Makefile > asn1/protocol/Nmake Makefile > asn1/Makefile.am (for packaging) > > It fixes the situation for the camel dissector. > It should also allow out of tree builds. > > 2do: > - No testing of the nmake makefiles. > - I don't know whether building the *-exp.cnf files will > work with the current syntax with nmake. Otherwise maybe > we could add another variable to Makefile.inc.nmake that > replaces MAKEFLAGS. > > If you basically like the solution, then could someone who > knows asn2wrs.py please check the changes to asn2wrs.py? > I'm neither familiar with python, nor with asn2wrs.py, so > I may have done somthing wrong/suboptimal. > > So let me know what things I missed/got wrong and what could/should > be improved. > > Otherwise (or if you fixed the things that needed fixing) please > check in the patch, as I don't have time to take care of it for at > least another week. > > Once this is done, the build process of the remaining asn1 dissectors > can be converted one by one. > > Ciao > Joerg > _______________________________________________ Wireshark-dev mailing list [email protected] http://www.wireshark.org/mailman/listinfo/wireshark-dev
