Hi, When what happens? Probably the buildbots are going to be oke, but is that enough. Is that equal to "every single current and historical system variant". I guess not. So I think we have to look harder before we start.
Thanx, Jaap Anders Broman wrote: > Hi, > Why not check in a subset of the changes and see what happens, if > there's a problem we can easily roll back. > Regards > Anders > > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Jaap Keuter > Sent: den 17 oktober 2008 07:33 > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] stdio.h/stdlib.h includes apparently not > req'd in epan/dissector source files .... > > Bill Meier wrote: >> Just for the record: My original reply to John follows (which I >> mistakenly sent only to John). >> >> >> John Sullivan wrote: >> > >> > Random *local* include files I would whole heartedly agree, but not > >>> system ones unless you have tested on every single current and > >> historical system variant. >> >> >> Certainly a valid point..... >> >> I'll hold off for now. >> >> Interestingly enough, I do note that just about half of the >> epan/dissector .c source files do not include stdio.h (and more than >> half do not include stdlib.h) and I've not heard of any issues with >> NULL & etc (although I don't know if anyone has built Wireshark with > GCC 4.3). >> Bill > Hi, > > From About Wireshark: "Built using gcc 4.3.1.", as every Debian/Testing > installation has. So that shouldn't be a problem. Maybe it's 4.3.0 > specific. > > Thanx, > Jaap _______________________________________________ Wireshark-dev mailing list [email protected] https://wireshark.org/mailman/listinfo/wireshark-dev
