Hi, Well if we should require GTK 2.6 as the minimum GTK version or not is a biger question (2.14 is the current) So perhaps we should. I think we allready have a few #if GTK_CHECK_VERSION(2,6,0) in the code.
In the meantime i guess "#if GTK_CHECK_VERSION(2,6,0)" is the way to go. Regards Anders -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Guy Harris Sent: den 26 februari 2009 20:39 To: [email protected] Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 27554: /trunk/gtk//trunk/gtk/: rtp_analysis.c On Feb 26, 2009, at 8:46 AM, [email protected] wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=27554 > > User: etxrab > Date: 2009/02/26 08:46 AM > > Log: > Another small performance boost. > > Directory: /trunk/gtk/ > Changes Path Action > +17 -25 rtp_analysis.c Modified Another small performance boost that requires GTK+ 2.6 or later, as it introduces a call to gtk_list_store_insert_with_values(). Should we remove that performance boost, or remove it if you don't have GTK+ 2.6 or later, or require 2.6 or later? The Solaris 10 build is failing because it doesn't have gtk_list_store_insert_with_values() in GTK+; I don't know whether that's the GTK+ that comes with Solaris 10's Java Desktop Environment (in which case Solaris 10 users would have to install a newer GTK+ to run Wireshark) or not. ________________________________________________________________________ ___ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
