Hi, As this enhancement is limited to one function and and not that much code (I think ) it's still something to consider as the benefits are great and it can be delivered within a short timeframe. I think we should be strict about new functionality but not rigid. If we want the new packet list in 1.4 there's a lot of work left so a new release might be many month away. Regards Anders
________________________________ From: [email protected] [mailto:[email protected]] On Behalf Of Jaap Keuter Sent: den 26 augusti 2009 11:41 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Port Expert info changes to 1.2.2? -Significant performance improvement. Hi, Yeah, i know it's good. Hence it should be the attraction for 1.4, not 1.2. Otherwise where will it end? Again a reason to release stable before sharkfest'10 ;) Thanx, Jaap Sent from my iPhone On 26 aug 2009, at 10:41, "Anders Broman" <[email protected]> wrote: Hi, I've been doing some measurements on the improvements to the Export info functions: 61 Mb file 159047 Packets 118 844 Errors (UDP checksum). WS 1.2.1 Trunk Old packet list Trunk New packet list Load file: ~16s ~14s ~4s Memory used: 232 812 kb 182 324 kb 131 716 kb Start: Expert info comp: 1.35s ~10s ~10s Memory used: 299 028 241 336 kb 190 832 kb Add Expert info: 1.44s ~12s ~12s Memory used: 363 244 kb 291 528 kb 241 032kb As you can see there is a significant reduction in the time required to load the expert data in trunk. Some of the gain is probably Due to other changes but I still believe it would be worth it to port this even if it's new functionality or is the old behavior a bug? ;-) There is no significant change in memmory usage in expert infos. Regards Anders ________________________________________________________________________ ___ Sent via: Wireshark-dev mailing list <[email protected]> Archives: <http://www.wireshark.org/lists/wireshark-dev> http://www.wireshark.org/lists/wireshark-dev Unsubscribe: <https://wireshark.org/mailman/options/wireshark-dev> https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
