Joerg Mayer wrote: > On Sat, Oct 10, 2009 at 11:19:46AM +0200, Kovarththanan Rajaratnam wrote: >>> What's the idea of crating the subdir CMakefiles and the static libs? >>> I was happy to get rid of them as they add an unnecessary linking step. >>> Also, are you sure that linking a static lib into a dynamic one is OK? >>> The same question holds for the other static libs added by other commits. >>> >> The idea was that instead of lumping it all together in one file, we >> could split it up to make it easier to understand/maintain in the >> future. This is also the approach used by our current build setup and I >> hadn't heard anyone complaining about that so I just went ahead and >> replicated the same structure. > > IMO, it was done because it was convenient and "easier" with the old build > system. I don't think there's any better reason for it. The -Werror stuff > also caused a split into a "clean" and a "non-clean" lib, which can be > handled much better with the CMake mechanism (and which is near the top of > my todo list). > > I'd really like to undo that change, because I don't see any advantage in > doing it the "old" way.
Since I haven't heard any convicing arguments (from both sides ;) I think it would be great if other people could give their opnion on this subject. -- Best regards, Kovarththanan Rajaratnam ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
