Hi,
On Wed, Feb 03, 2010 at 01:05:32PM -0500, Brian Oleksa wrote:
> Jakub
>
> Thanks for this feedback. It is always good to have an extra set of eyes :-)
You missunderstood my comment about check_col()
instead of:
if (check_col(pinfo->cinfo, COL_PROTOCOL))
col_set_str(pinfo->cinfo, COL_PROTOCOL, PROTO_TAG_HELEN);
if (check_col(pinfo->cinfo, COL_INFO))
col_clear(pinfo->cinfo, COL_INFO);
Just write:
col_set_str(pinfo->cinfo, COL_PROTOCOL, PROTO_TAG_HELEN);
col_clear(pinfo->cinfo, COL_INFO);
> gfloat latitude;
> latitude = tvb_get_ntohieee_float(tvb,offset);
>
> Why do you think this variable is not being used..??
Well because it's not used :) What is used for?
And one more thing...
You declare: ett_helen_ipv6, ett_helen_nos, ...
I believe you need only ett_helen from ett_*
Cheers.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <[email protected]>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:[email protected]?subject=unsubscribe
