David Aggeler wrote: > In my opinion the numerous checks for check_col() in the dissectors.are > superfluous (and confusing). > All col_set_xxxx() functions in column-utils.c correctly check for the > precondition. > And the precondition is better placed in column-utils.c. Once done, > removing the export would be the logical consequence.
Yes, that's the direction now. But no one has bothered to go through all the old code and remove the checks. > As I don't have direct SVN access and since I'm not core member, I'm not > sure whether I should start this change. > Would a single .diff file do? Any objection or motivation do do so? I would guess one-big-diff would be a bit unwieldy (especially if the tree changed between when you generated it and when someone applied it). No reason not to go forward with it if you've got the time... ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
