This change removed the default of on for a ring buffer when using multiple files. It also changed the default snaplen from 1 to the maximum size of 65k if the "limit each packet to" box is checked in capture options. Both of these values were defined as such by capture_opts_init(), but then overriden with new values right after that call in gtk/main.c
If anyone thinks we should put these defaults back, we can change them in capture_opts_init() in /capture_opts.c. This change does have a visual effect showing what defaults are being used even when they're grayed out in the capture options dialog. But the reason I did it was because a user was having to specify -b files:0 on the command line to stop the default behavior of using a ring buffer with multiple files (to make it unlimited). The files:0 option worked, but the capture options dialog still showed the default lowest value if it's turned on of 2, causing confusion. Thus I also changed the option to be rejected if files is set to 0. On Tue, Sep 07, 2010 at 07:22:10PM +0000, [email protected] wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=34073 > > User: sfisher > Date: 2010/09/07 12:22 PM > > Log: > These two capture option variables are defined by capture_opts_init(), so > don't redefine them to new values. > > Directory: /trunk/gtk/ > Changes Path Action > +0 -3 main.c Modified > > ___________________________________________________________________________ > Sent via: Wireshark-commits mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-commits > Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits > > mailto:[email protected]?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
