Hi, 2010/10/25 Jeff Morriss <[email protected]>
> Pascal Quantin wrote: > > Hi, > > > > since revision 34640, none of UDP heuristic dissectors I use (LTE-MAC, > > LTE-RLC or LTE-PDCP) work: all the frames are decoded as ADwin > > configuration protocol. > > > > When looking at the code in function dissect_adwin_config() (file > > packet-adwin-config.c), the heuristic seems a bit weak: > > [...] > > length = tvb_reported_length(tvb); > > > > if (pinfo->ipproto == IP_PROTO_UDP && > > ! (length == UDPStatusLENGTH > > || length == UDPExtStatusLENGTH > > || length == UDPMessageLENGTH > > || length == UDPMessageLENGTH_wrong > > || length == UDPInitAckLENGTH > > || length == UDPIXP425FlashUpdateLENGTH > > || length == UDPOutLENGTH)) > > return (0); > > [...] > > > > Could it be possible to do something more robust ? > > Oops, sorry. We're discussing some stronger heuristics in bug 5324. > While you iterate on it, would it be possible to add a preference (off by default) stating whether the ADwin heuristic dissectors are activated or not (like what is done in packet-mac-lte.c for example) ? Regards, Pascal.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
