Hi,
Trivial patch, len is already unsigned (guint32) so it can't be negative ;)
Cheers.
diff --git epan/reassemble.c epan/reassemble.c
index 3080997..574a0c2 100644
--- epan/reassemble.c
+++ epan/reassemble.c
@@ -966,7 +966,7 @@ fragment_add_work(fragment_data *fd_head, tvbuff_t *tvb,
const int offset,
fd_i->len-(dfpos-fd_i->offset));
}
} else {
- if (fd_i->offset + fd_i->len < fd_i->offset) /*
XXX what? This only tests if fd_i->len is negative */
+ if (fd_i->offset + fd_i->len < fd_i->offset) /*
Integer overflow? */
g_warning("Reassemble error in frame
%u: offset %u + len %u < offset",
pinfo->fd->num, fd_i->offset,
fd_i->len);
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <[email protected]>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:[email protected]?subject=unsubscribe
