Coverity CID 322 is an "assert with side effect" warning in
/epan/dissectors/packet-x11.c:dissect_x11_replies(). While it would be easy to
eliminate this warning by assigning 'plen' to a temporary variable and then
using that in the DISSECTOR_ASSERT() macro instead of 'plen', I found myself
asking why 'plen' is declared as a volatile int to begin with. It seems like
the better solution would just be to eliminate the volatile keyword.
But then I went looking for other volatile's and found a number of them:
grep volatile epan/dissectors/packet-*.c | wc
184 1066 14209
Do we really need any of these in Wireshark?
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <[email protected]>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:[email protected]?subject=unsubscribe
