On 4/23/11 3:12 PM, Guy Harris wrote: > > On Apr 23, 2011, at 11:29 AM, Jakub Zawadzki wrote: > >> About actual bug: >> In old packet list _freeze stops GtkClist from redraw while adding packets >> to list. >> In new packet list _freeze sets empty (NULL) model, and _thaw restores model >> with packets. > > Are there any places where freezing and thawing the list is useful any more? > > The freezing/thawing code dates back to at least SVN r2 (no, that is *NOT* a > typo!) of file.c: > > ------------------------------------------------------------------------ > r2 | gerald | 1998-09-15 19:39:15 -0700 (Tue, 15 Sep 1998) | 2 lines > > Initial revision > > ------------------------------------------------------------------------ > > Gerald, do you remember (from almost 13 years ago!) why you froze the > GtkCList when reading the capture in and thawed it when done? Is this > something that applied to the old GTKCList but that doesn't apply to GTK2's > tree view?
I'm pretty sure it was for performance reasons. Each change to the packet list triggered a lot of synchronous updates which you could defer by freezing and thawing the list. -- Join us for Sharkfest ’11! · Wireshark® Developer and User Conference Stanford University, June 13-16 · http://sharkfest.wireshark.org ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
