On 2012-06-19 19:42, Guy Harris wrote:
I only verified it on Linux so It needs to be verified for other platforms 
first.
What's Linux-specific about it?  It's a change to GUI code, and we're using a toolkit 
that does the same thing on all UN*X+X11 platforms (i.e., on everything except for 
Windows, given that we're not using the "native" GTK+ on OS X) and, even on 
non-X11 platforms, is pretty much only different in the lower-level drawing code.
Yeah. I know, but I'm not experienced with GTK so I was worried I messed something up.

The wireless toolbar code *is*, I think, Linux-specific (as libpcap doesn't yet 
have APIs to get lists of available channels or set the channel on 802.11 
adapters), and the patch to update the interface list when new interfaces 
appear is probably Linux-specific as well, but that's different from a pure GUI 
change.
Indeed. For both patches I have kept the GUI code OS independent of the OS specific parts. The OS specific parts is kept in a separate file. Currently only Linux is supported but adding support for other OSs should be fairly easy, at least for the interface hotplug patch.

Cheers,

Pontus

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:[email protected]?subject=unsubscribe

Reply via email to