Recently, I found and fixed some of these problems, but obviously I didn't catch them all. Are there any more thoughts about changing tvb_length_remaining() and tvb_reported_length_remaining() to return 0 instead of -1?
- Chris Ref: http://www.wireshark.org/lists/wireshark-dev/201207/msg00064.html ________________________________________ From: [email protected] [[email protected]] On Behalf Of [email protected] [[email protected]] Sent: Monday, October 15, 2012 6:34 PM To: [email protected] Subject: [Wireshark-commits] rev 45566: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rdp.c http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=45566 User: martink Date: 2012/10/15 03:34 PM Log: (try to) fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7862 tvb_length_remaining() may return -1 if that happens in dissect_rdp_fields(), return an error the caller that calls dissect_rdp_fields() from a for loop detects the error and exits (others should handle the error as well, this is missing for now) Directory: /trunk/epan/dissectors/ Changes Path Action +8 -2 packet-rdp.c Modified -- CONFIDENTIALITY NOTICE: The information contained in this email message is intended only for use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately delete it from your system and notify the sender by replying to this email. Thank you. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
