Evan Huus wrote:
On Mon, Nov 19, 2012 at 4:00 PM, <[email protected] <mailto:[email protected]>> wrote:

    http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46087
    <http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46087>

    User: morriss
    Date: 2012/11/19 01:00 PM

    Log:
     I'm pretty confident the string length will fit in 32 bits; cast
    away the "possible loss of data" warning on the Win64 build.

    Directory: /trunk/
      Changes    Path              Action
      +11 -11    capture_opts.c    Modified


Not that I really think the string is likely to exceed 2^32 characters, but wouldn't it be saner to declare prefix_length as a size_t instead?

Yeah, you have a point. :-)  Fixed in r46088.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:[email protected]?subject=unsubscribe

Reply via email to