Two points of interest here: - The original fix in trunk was a coverity fix and wasn't backported at the time (I assume) because it wasn't known to fix an actual crash. Should we have some sort of policy to avoid this, by e.g. backporting fixes for all coverity issues when possible?
- The exact check being made happens in two different places in trunk with *exactly* the same code. Is that intentional (in which case there should be an explanatory comment) or can one of them be removed? Cheers, Evan On Wed, Jan 30, 2013 at 7:41 PM, <[email protected]> wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47381 > > User: eapache > Date: 2013/01/30 04:41 PM > > Log: > Manually rediscover r43185 to fix > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8274 > > Directory: /trunk-1.8/epan/dissectors/ > Changes Path Action > +1 -1 packet-tcp.c Modified > > ___________________________________________________________________________ > Sent via: Wireshark-commits mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-commits > Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits > > mailto:[email protected]?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
