On Feb 26, 2013, at 11:46 AM, Bálint Réczey <[email protected]> wrote:

> I have created the attached patch to control symbol visibility using
> C defines instead of .def and .sym files.

You might want to use comments on #else and #endif to make it a bit easier to 
figure out what #else is the opposite of and what #endif terminates.

> It is expected to work on every platform and every build system we support,

"Work" as in "not fail to compile", or "work" as in "keep symbols from being 
exported outside the library if not marked as being exported by the library"?

At least some UN*X compilers might support GCC-style 
__attribute__(visibility(...)) options, but I don't know whether all the ones 
that would be used to compile Wireshark, on platforms where the linker can hide 
symbols, do.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:[email protected]?subject=unsubscribe

Reply via email to