Hi Jakub, Thank for the catching !
Fix in revision 53444 Regards, On Wed, Nov 20, 2013 at 12:08 AM, Jakub Zawadzki <[email protected]>wrote: > Hello Alexis, Peter, > > Looking at r53416 [1] diff, I found two things in packet-ssl.c strange > > > 2861 dissect_ssl3_hnd_hello_ext_status_request_v2(tvbuff_t *tvb, > proto_tree *tree, > > 2869 while (list_len-- > 0) > 2870 offset += dissect_ssl3_hnd_hello_ext_status_request(tvb, > tree, offset, TRUE); > > // but dissect_ssl3_ocsp_response() return offset not delta. > > > 3929 dissect_ssl3_hnd_cert_status(tvbuff_t *tvb, proto_tree *tree, > > 3950 while (list_len-- > 0) > 3951 offset += dissect_ssl3_ocsp_response(tvb, tree, > offset, pinfo); > > // but dissect_ssl3_ocsp_response() return offset not delta. > > > I think in both cases it should be '=' not '+=' > > Could you please check it? > Thanks, > > Kuba. > > [1] > http://code.wireshark.org/git/?p=wireshark;a=commitdiff;h=123e3d92039770c0a36c4be97ae34c1ef27c4f8e > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected] > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
