As far as I know we do attempt to freeze the API for minor versions; I believe we even have a build script that is supposed to catch such breakages and report them. I wonder why it did not catch this one?
Evan On Sat, Mar 29, 2014 at 9:10 AM, Eshed Shaham <[email protected]> wrote: > Hello, > > I recently found out that the frame_data structure had a minor change in the > 1.8 branch between 1.8.8 and 1.8.9: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=blobdiff;f=epan/frame_data.h;h=5ab320541760d412a11ad23422e29b8b8e88635e;hp=dc4f177a34f5a1cd00c2d754f63440301db42f09;hb=0a28fb8f6a354aa9a446b6bf70733c305534e074;hpb=27b5d556cb53bee24e20a9bb5862189ee2e55a61 > > Unfortunately, this minor change broke my plugin's (pyreshark) interfacing > with Wireshark, with a fix requiring either having two versions for the 1.8 > branch (I currently provide a single version of the plugin for every minor > version (1.8, 1.10) of Wireshark) or adding some ugly hack to determine the > version during runtime. > > While I can't say it's critical, as I only discovered this change nearly a > year after it was introduced, I do see merit in freezing the API in minor > versions, to keep plugin versions at a minimum. > > I apologise if the above seems accusative, I'm not a native English speaker, > so my words might have conveyed the wrong message. My intention was to bring > this issue to your attention with the hope that in the future you'll take it > into consideration during future development. > > Thanks for all your hard work! > Eshed > > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected]?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
