On 4/25/14 10:06 AM, Andrew Bitson wrote: > Hello, > > I am interested in tackling a particular bug: > <https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9985> but being new > to the Wireshark source, I’d like some tips on where to look first. > > Where in the source tree would the optimal location be to address this > bug? I have been thinking that the ui/gtk/oi_stat.c file would be ideal, > but am not familiar with the data structures used or other method calls.
Are you working from a recent master? If so most of the arithmetic grunt work has been moved to ui/io_graph_item.c. It's used by both ui/gtk/io_stat.c and ui/qt/io_graph_dialog.cpp. With respect to the actual bug, are you proposing to add a separate "ABS" calculation? If so you'd add an entry io_graph_item_unit_t in io_graph_item.h and work from there. Otherwise you could add a "Use absolute values" setting for each dialog similar to the smoothing setting. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
