Hi Evan, 2014-06-03 20:09 GMT+02:00 Evan Huus <[email protected]>:
> Just create it once in the init routine, rather than when the first uuid > is registered? Then you can guarantee it always exists. > This is what I initially did but changed my mind at the last minute as checking the existence of the table is less expensive than building the lookup key and calling wmem_map_lookup while it will never succeed. So I saw it as a micro optimization :) > > On Tue, Jun 3, 2014 at 2:01 PM, Wireshark code review < > [email protected]> wrote: > >> URL: >> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5de173edc09cceb7c351cf8b85a470ad597be17 >> Submitter: Pascal Quantin ([email protected]) >> Changed: branch: master >> Repository: wireshark >> >> Commits: >> >> c5de173 by Pascal Quantin ([email protected]): >> >> MBIM: do not access to hash map when it is not initialized yet >> >> Change-Id: I560941115316ead5a85b9e0b55be693217fddff2 >> Reviewed-on: https://code.wireshark.org/review/1940 >> Reviewed-by: Pascal Quantin <[email protected]> >> >> >> Actions performed: >> >> from 9389d78 Qt: Export Object * Fix indent (remove tabs) * Add >> title to the window >> adds c5de173 MBIM: do not access to hash map when it is not >> initialized yet >> >> >> Summary of changes: >> epan/dissectors/packet-mbim.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> ___________________________________________________________________________ >> Sent via: Wireshark-commits mailing list < >> [email protected]> >> Archives: http://www.wireshark.org/lists/wireshark-commits >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits >> mailto:[email protected] >> ?subject=unsubscribe >> > > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected] > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
