With this change, the comment at wiretap/libpcap.c:769 is stale since it still references 64KB. Not a major issue, but makes me wonder where else in the code we've accidentally hardcoded that assumption... I guess we'll find out :)
On Wed, Jun 25, 2014 at 4:27 PM, Wireshark code review < [email protected]> wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8cde7a72d6c2b8e5cac87aeec5b1f200185cbe4a > Submitter: Guy Harris ([email protected]) > Changed: branch: master > Repository: wireshark > > Commits: > > 8cde7a7 by Guy Harris ([email protected]): > > Boost the maximum packet size to 131072. > > Libpcap 1.6/tcpdump 4.6 will support up to 131072, as the MTU on the > Linux loopback device is 65536 on at least some versions of the kernel, > and that doesn't count the fake Ethernet header, so the maximum packet > size is 65549; they went to the next power of 2 up. > > Change-Id: Ibfc66d01ef8ef7387887a75c2b567159bb78ac0f > Reviewed-on: https://code.wireshark.org/review/2655 > Reviewed-by: Guy Harris <[email protected]> > > > Actions performed: > > from fd5b077 DLSw: better fix, as suggested by Evan > adds 8cde7a7 Boost the maximum packet size to 131072. > > > Summary of changes: > wiretap/wtap.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > ___________________________________________________________________________ > Sent via: Wireshark-commits mailing list < > [email protected]> > Archives: http://www.wireshark.org/lists/wireshark-commits > Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits > mailto:[email protected] > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
