On Tuesday 25 November 2014 23:37:26 Pascal Quantin wrote: > 2014-11-25 18:59 GMT+01:00 Alexis La Goutte <[email protected]>: > > For information, > > I have add the check of last commit > > the Ubuntu Petri Dish buildbot launch a ./tools/pre-commit HEAD^1 > > (launch check[APIs|hf|filenames] on tested commit) > > > > It is possible to have same "false" postive warnings errors.... > > unfortunately (as expected) it can trigger some false positives making > Petri Dish fail (like for example > http://buildbot.wireshark.org/petri-dish/builders/Ubuntu%20x86-64%20Petri%20Dish/builds/813/steps/Pre-commit%20check/logs/stdio > even if this one could be questionable). I know that the script can choke > on some ASN.1 auto generated dissectors. Maybe we are not ready for this > yet...
Is it possible to make the buildbot add a Code-Review -1 instead of setting the Verified flag for pre-commit failures? -- Kind regards, Peter https://lekensteyn.nl ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
