On 28 Nov 2014, at 17:13, Peter Wu <[email protected]> wrote: > Hi, > > I came across a duplicated piece of code by grepping for the string "DLT > n" which I originally found in ui/gtk/capture_dlg.c. Two questions: > > - Can somebody reduce the duplication (two occurrences in > ui/gtk/capture_dlg.c, one in ui/qt/manage_interfaces_dialog.cpp)? > - Why is the callback for capture_prep_monitor_changed_cb so huge? > > There is a crash in certain circumstances, and > capture_prep_monitor_changed_cb is involved: > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10685 > > cc'ing Michael Tüxen as he extended capture_prep_monitor_changed_cb in > commit eaffdfeaaa572bb818f116afb3c63b3d43c153ea > Date: Fri Aug 5 07:19:17 2011 +0000 > > Add support for multiple interfaces to the capture options dialog. > Obtained from Irene Ruengeler. CC'ing Irene, since the code was developed by her...
Best regards Michael > -- > Kind regards, > Peter > https://lekensteyn.nl > > ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
