On Thu, Jan 8, 2015 at 11:50 AM, Pascal Quantin <pascal.quan...@gmail.com> wrote:
> 2015-01-08 11:38 GMT+01:00 Dario Lombardo <dario.lombardo...@gmail.com>: > >> Hi list >> I pushed a patch a couple of days ago >> >> https://code.wireshark.org/review/#/c/6350/ >> >> I think it's getting stuck for some reason (not even the petri dish >> buildbot has processed it). >> >> Other patches submitted later (eg. https://code.wireshark.org/review/6394 >> or https://code.wireshark.org/review/6367) have been or are being >> processed. >> Is there any reason for that? I'm not pushing anyone... just wondering if >> for some reason it is blocked. >> >> Thanks >> Dario. >> >> > Hi Dario, > > it simply means that no one had the time to review it yet. The first > comment I can say (iwthotu goint too much into details) is that in my > opinion jsmn.* files should not go in dissectors folder (where we have real > dissectors and not utility functions). So it should go somehwere else, but > I'm not sure about the location (maybe in epan folder). > +1 Like in epan/jsmn (like for nghttp2) > > Regards, > Pascal. > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
